From: Tejun Heo <tj@kernel.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: ide <linux-ide@vger.kernel.org>, Jeff Garzik <jeff@garzik.org>,
stable@kernel.org
Subject: Re: [PATCH] pata_amd: do not filter out valid modes in nv_mode_filter
Date: Mon, 14 Sep 2009 18:21:52 +0900 [thread overview]
Message-ID: <4AAE0B30.1050608@kernel.org> (raw)
In-Reply-To: <4AAC8927.4030401@gmail.com>
Robert Hancock wrote:
> On a Compaq Presario V3000 laptop (NVIDIA MCP51 chipset), pata_amd selects
> PIO0 mode for the PATA DVD-RAM drive instead of MWDMA2 which it supports:
>
> ata4.00: ATAPI: HL-DT-ST DVDRAM GSA-4084N, KQ09, max MWDMA2
> ata4: nv_mode_filter: 0x39f&0x7001->0x1, BIOS=0x0 (0x0) ACPI=0x7001 (60:600:0x11)
> ata4.00: configured for PIO0
>
> For some reason, the BIOS-set UDMA configuration returns 0 and the ACPI _GTM
> reports that UDMA2 and PIO0 are enabled. This causes nv_mode_filter to end up
> allowing only PIO0 and UDMA0-2. Since the drive doesn't support UDMA we end up
> using PIO0.
>
> Since the controllers should always support PIO4, MWDMA2 and UDMA2 regardless
> of what cable type is used, let's make sure we don't filter out these modes
> regardless of what wacky settings the BIOS is using.
>
> Signed-off-by: Robert Hancock <hancockrwd@gmail.com>
> Cc: stable@kernel.org
Looks good to me.
Acked-by: Tejun Heo <tj@kernel.org>
Not so sure whether this is -stable material yet tho.
--
tejun
next prev parent reply other threads:[~2009-09-14 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 5:54 [PATCH] pata_amd: do not filter out valid modes in nv_mode_filter Robert Hancock
2009-09-14 9:21 ` Tejun Heo [this message]
2009-09-17 20:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAE0B30.1050608@kernel.org \
--to=tj@kernel.org \
--cc=hancockrwd@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).