From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: Commit 54c38444fad6a99b4b19512f8f0055d69115e69e
Date: Thu, 17 Sep 2009 16:30:42 +0900 [thread overview]
Message-ID: <4AB1E5A2.5090006@kernel.org> (raw)
In-Reply-To: <4AB1E116.6030600@garzik.org>
Jeff Garzik wrote:
> On 09/16/2009 07:56 AM, Tejun Heo wrote:
>> Jeff,
>>
>> Commit 54c38444fad6a99b4b19512f8f0055d69115e69e triggers
>> WARN_ON_ONCE(ap->pflags& ATA_PFLAG_FROZEN); in ata_qc_complete().
>>> From the commit history, it seems the change was to add DMA engine
>> disable to sil_freeze(), right? I can't see why changing the orders
>> would matter there. ata_port_abort() just changes the internal state
>> of libata and doesn't affect low level driver or the hardware.
>
> ata_port_abort does more than change internal state: it calls
> ata_qc_complete, which could trigger a taskfile register read.
>
> All SFF BMDMA controllers /must/ disable the DMA engine, before touching
> the taskfile device register block.
Ah.. right, the result tf filling. Well, then, I guess we'll have to
move the WARN_ON_ONCE(). I'll post a patch soon.
Thanks.
--
tejun
prev parent reply other threads:[~2009-09-17 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 11:56 Commit 54c38444fad6a99b4b19512f8f0055d69115e69e Tejun Heo
2009-09-17 7:11 ` Jeff Garzik
2009-09-17 7:30 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB1E5A2.5090006@kernel.org \
--to=tj@kernel.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).