From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: ide <linux-ide@vger.kernel.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] ahci: display all AHCI 1.3 HBA capability flags
Date: Sun, 20 Sep 2009 16:39:52 -0400 [thread overview]
Message-ID: <4AB69318.5050904@garzik.org> (raw)
In-Reply-To: <4AB6718C.2050107@gmail.com>
On 09/20/2009 02:16 PM, Robert Hancock wrote:
> @@ -2534,13 +2535,14 @@ static void ahci_print_info(struct ata_host *host)
> struct ahci_host_priv *hpriv = host->private_data;
> struct pci_dev *pdev = to_pci_dev(host->dev);
> void __iomem *mmio = host->iomap[AHCI_PCI_BAR];
> - u32 vers, cap, impl, speed;
> + u32 vers, cap, cap2, impl, speed;
> const char *speed_s;
> u16 cc;
> const char *scc_s;
>
> vers = readl(mmio + HOST_VERSION);
> cap = hpriv->cap;
> + cap2 = readl(mmio + HOST_CAP2);
1) We cannot unconditionally read from this register location on all
chips, as it's undefined for many chips. Add a chip version check or
somesuch.
2) Treat cap2 in the same manner as cap, to prepare for potential future
usages.
Jeff
next prev parent reply other threads:[~2009-09-20 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 18:16 [PATCH] ahci: display all AHCI 1.3 HBA capability flags Robert Hancock
2009-09-20 20:39 ` Jeff Garzik [this message]
2009-09-20 23:02 ` [PATCH] ahci: display all AHCI 1.3 HBA capability flags (v2) Robert Hancock
2009-09-29 2:34 ` Robert Hancock
2009-09-30 23:02 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB69318.5050904@garzik.org \
--to=jeff@garzik.org \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).