From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: ide <linux-ide@vger.kernel.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] ahci: display all AHCI 1.3 HBA capability flags (v2)
Date: Wed, 30 Sep 2009 19:02:27 -0400 [thread overview]
Message-ID: <4AC3E383.3030508@garzik.org> (raw)
In-Reply-To: <51f3faa70909281934o38b23679w72b8231e762412ba@mail.gmail.com>
On 09/28/2009 10:34 PM, Robert Hancock wrote:
> On Sun, Sep 20, 2009 at 5:02 PM, Robert Hancock<hancockrwd@gmail.com> wrote:
>> Update the AHCI driver to display all of the HBA capabilities defined in the
>> AHCI 1.3 specification. Some of these are in a new CAP2 (HBA Capabilities
>> Extended) register which is only defined on AHCI 1.2 or later. The spec says
>> that undefined registers should always return 0 on read, but to be safe we
>> assume a value of 0 unless the controller reports AHCI version 1.2 or later.
>> The value can also be retrieved through sysfs as with the existing capability
>> field.
>>
>> For example, on an Intel Ibex Peak (PCH) controller:
>>
>> ahci 0000:00:1f.2: flags: 64bit ncq sntf stag pm led clo pmp pio slum part ems
>> sxs apst
>>
>> We don't do anything special with the new flags yet.
>>
>> Also, change the code that displays the flags to use the same bit enumerations
>> that are used to control actual operation.
>>
>> Signed-off-by: Robert Hancock<hancockrwd@gmail.com>
>>
>
> Ping?
in the queue, but I want to get some serious libata testing (today)
before pushing stuff. I'm seeing some strange timeouts, on ICH7 AHCI
ATAPI, and need to check and see whether (a) libata broke recently or
(b) more likely, the hardware is dying.
Jeff
prev parent reply other threads:[~2009-09-30 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 18:16 [PATCH] ahci: display all AHCI 1.3 HBA capability flags Robert Hancock
2009-09-20 20:39 ` Jeff Garzik
2009-09-20 23:02 ` [PATCH] ahci: display all AHCI 1.3 HBA capability flags (v2) Robert Hancock
2009-09-29 2:34 ` Robert Hancock
2009-09-30 23:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC3E383.3030508@garzik.org \
--to=jeff@garzik.org \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).