* ahci_gtf_filter_workaround function breaks current git build
@ 2009-10-09 3:41 Markus Trippelsdorf
2009-10-09 4:00 ` Tejun Heo
2009-10-09 4:30 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Markus Trippelsdorf @ 2009-10-09 3:41 UTC (permalink / raw)
To: linux-ide; +Cc: jeff, tj
ahci: Add ifdef wrapper to ahci_gtf_filter_workaround
Commit f80ae7e45a0e03da188494c6e947a5c8b0cdfb4a
ahci: filter FPDMA non-zero offset enable for Aspire 3810T
breaks the current git build for configurations that don't define
CONFIG_ATA_ACPI.
This adds an ifdef wrapper to ahci_gtf_filter_workaround.
Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 4edca6e..b1a2577 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -2884,6 +2884,7 @@ static bool ahci_broken_online(struct pci_dev *pdev)
return pdev->bus->number == (val >> 8) && pdev->devfn == (val & 0xff);
}
+#ifdef CONFIG_ATA_ACPI
static void ahci_gtf_filter_workaround(struct ata_host *host)
{
static const struct dmi_system_id sysids[] = {
@@ -2927,6 +2928,10 @@ static void ahci_gtf_filter_workaround(struct ata_host *host)
dev->gtf_filter |= filter;
}
}
+#else
+static inline void ahci_gtf_filter_workaround(struct ata_host *host)
+{}
+#endif
static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
--
Markus
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: ahci_gtf_filter_workaround function breaks current git build
2009-10-09 3:41 ahci_gtf_filter_workaround function breaks current git build Markus Trippelsdorf
@ 2009-10-09 4:00 ` Tejun Heo
2009-10-09 4:30 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2009-10-09 4:00 UTC (permalink / raw)
To: Markus Trippelsdorf; +Cc: linux-ide, jeff
Markus Trippelsdorf wrote:
> ahci: Add ifdef wrapper to ahci_gtf_filter_workaround
>
> Commit f80ae7e45a0e03da188494c6e947a5c8b0cdfb4a
> ahci: filter FPDMA non-zero offset enable for Aspire 3810T
> breaks the current git build for configurations that don't define
> CONFIG_ATA_ACPI.
> This adds an ifdef wrapper to ahci_gtf_filter_workaround.
>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Acked-by: Tejun Heo <tj@kernel.org>
Thank you.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ahci_gtf_filter_workaround function breaks current git build
2009-10-09 3:41 ahci_gtf_filter_workaround function breaks current git build Markus Trippelsdorf
2009-10-09 4:00 ` Tejun Heo
@ 2009-10-09 4:30 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2009-10-09 4:30 UTC (permalink / raw)
To: Markus Trippelsdorf; +Cc: linux-ide, tj
On 10/08/2009 11:41 PM, Markus Trippelsdorf wrote:
> ahci: Add ifdef wrapper to ahci_gtf_filter_workaround
>
> Commit f80ae7e45a0e03da188494c6e947a5c8b0cdfb4a
> ahci: filter FPDMA non-zero offset enable for Aspire 3810T
> breaks the current git build for configurations that don't define
> CONFIG_ATA_ACPI.
> This adds an ifdef wrapper to ahci_gtf_filter_workaround.
>
> Signed-off-by: Markus Trippelsdorf<markus@trippelsdorf.de>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-09 4:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-09 3:41 ahci_gtf_filter_workaround function breaks current git build Markus Trippelsdorf
2009-10-09 4:00 ` Tejun Heo
2009-10-09 4:30 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).