From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: Ethan <ethanhsiao@jmicron.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] libata: fix internal command failure handling
Date: Fri, 16 Oct 2009 06:27:15 -0400 [thread overview]
Message-ID: <4AD84A83.5010601@garzik.org> (raw)
In-Reply-To: <4AD7EFF3.1000902@kernel.org>
On 10/16/2009 12:00 AM, Tejun Heo wrote:
> When an internal command fails, it should be failed directly without
> invoking EH. In the original implemetation, this was accomplished by
> letting internal command bypass failure handling in ata_qc_complete().
> However, later changes added post-successful-completion handling to
> that code path and the success path is no longer adequate as internal
> command failure path. One of the visible problems is that internal
> command failure due to timeout or other freeze conditions would
> spuriously trigger WARN_ON_ONCE() in the success path.
>
> This patch updates failure path such that internal command failure
> handling is contained there.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Cc: stable@kernel.org
> ---
> drivers/ata/libata-core.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
applied -- thanks for fixing!!
prev parent reply other threads:[~2009-10-16 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 4:00 [PATCH #upstream-fixes] libata: fix internal command failure handling Tejun Heo
2009-10-16 10:27 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD84A83.5010601@garzik.org \
--to=jeff@garzik.org \
--cc=ethanhsiao@jmicron.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).