From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Philippe De Muyter <phdm@macqel.be>
Cc: David Miller <davem@davemloft.net>,
hancockrwd@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH ide] : Increase WAIT_DRQ to support slow CF cards
Date: Tue, 27 Oct 2009 13:24:48 +0300 [thread overview]
Message-ID: <4AE6CA70.3000002@ru.mvista.com> (raw)
In-Reply-To: <20091027094503.GA3116@frolo.macqel>
Hello.
Philippe De Muyter wrote:
>> From: Robert Hancock <hancockrwd@gmail.com>
>> Date: Mon, 26 Oct 2009 19:40:03 -0600
>>
>>
>>> On Mon, Oct 26, 2009 at 7:19 PM, David Miller <davem@davemloft.net> wrote:
>>>
>>>> Meanwhile we should provide a way for things to work, and
>>>> realistically the only way to do that currently is to bump the
>>>> WAIT_DRQ value to some large number.
>>>>
>>>> And that's exactly the kind of patch I'm willing to accept for this.
>>>>
>>> I agree, it's sub-optimal but it helps.. if the user wants better
>>> behavior they should a) fix it so that the card isn't using PIO, at
>>> least if it supports DMA and b) not use drivers/ide..
>>>
>
> Strangely enough, I also had no timeout problem if I started my kernel with
> 'ide=nodma', instead of increasing WAIT_DRQ.
Hm, interesting...
> So I surmise that WAIT_DRQ is used in the dma case.
>
>
It's used only for the PIO write commands -- see do_rw_taskfile() in
ide-taskfile.c... DMA commands don't require waiting for BSY=0, DRQ=1
condition.
> Philippe
>
WBR, Sergei
next prev parent reply other threads:[~2009-10-27 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 16:20 [PATCH ide] : Increase WAIT_DRQ to support slow CF cards Philippe De Muyter
2009-10-27 0:34 ` Robert Hancock
2009-10-27 0:45 ` David Miller
2009-10-27 1:07 ` Robert Hancock
2009-10-27 1:19 ` David Miller
2009-10-27 1:40 ` Robert Hancock
2009-10-27 1:43 ` David Miller
2009-10-27 9:45 ` Philippe De Muyter
2009-10-27 10:24 ` Sergei Shtylyov [this message]
2009-10-31 13:56 ` Mark Lord
2009-12-03 5:57 ` David Miller
2009-12-03 8:55 ` Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE6CA70.3000002@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).