From: Tejun Heo <tj@kernel.org>
To: Chaitanya Lala <clala@riverbed.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
ajones@riverbed.com, rbecker@riverbed.com
Subject: Re: [libata PATCH 1/1] libata: thaw port after maximum reset retries
Date: Mon, 09 Nov 2009 17:17:25 +0900 [thread overview]
Message-ID: <4AF7D015.1010703@kernel.org> (raw)
In-Reply-To: <20090911152703.GA5222@clala-laptop>
Chaitanya Lala wrote:
> The libata error recovery tries to reset a port a number
> of times and if unsuccessful, gives up. The code does not
> thaw the port before it exits. If the bad disk i.e. the disk
> that could not be reset is removed and a healthy disk is
> inserted, the new disk does not register, since the port is
> frozen. This patch fixes the same.
Sorry about the long delay but has this actually happen? The
rationale for not thawing there was that if the port was behaving
erratically, it could cause IRQ storm and thus take the whole
controller down and the port can be revived by issuing rescan if the
administrator intends to do so.
Thanks.
--
tejun
prev parent reply other threads:[~2009-11-09 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 15:27 [libata PATCH 1/1] libata: thaw port after maximum reset retries Chaitanya Lala
2009-11-09 8:17 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF7D015.1010703@kernel.org \
--to=tj@kernel.org \
--cc=ajones@riverbed.com \
--cc=clala@riverbed.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=rbecker@riverbed.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).