From: Mark Lord <liml@rtr.ca>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Thiago Farina <tfransosi@gmail.com>,
jgarzik@pobox.com, mlord@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: Clean up hard coded array size calculation.
Date: Wed, 11 Nov 2009 17:37:17 -0500 [thread overview]
Message-ID: <4AFB3C9D.4020609@rtr.ca> (raw)
In-Reply-To: <84144f020911100808y55f5bfa2v5c203b356583a7b5@mail.gmail.com>
Pekka Enberg wrote:
> On Tue, Nov 10, 2009 at 5:51 PM, Bartlomiej Zolnierkiewicz
> <bzolnier@gmail.com> wrote:
>>> I have to go off and research some silly macro and verify that
>>> it does the right thing.
>> You did it already and the macro name is quite descriptive so you
>> may as well just ACK the patch now.. ;)
>
> Indeed. We use the "silly macro" everywhere in the kernel for code clarity.
..
Looks like unnecessary churn and obfuscation to me.
-ml
next prev parent reply other threads:[~2009-11-11 22:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 19:30 [PATCH] ata: Clean up hard coded array size calculation Thiago Farina
2009-11-08 19:45 ` Thiago Farina
2009-11-10 5:00 ` Mark Lord
2009-11-10 15:51 ` Bartlomiej Zolnierkiewicz
2009-11-10 16:08 ` Pekka Enberg
2009-11-11 22:37 ` Mark Lord [this message]
2009-11-11 22:50 ` Thiago Farina
2009-11-12 23:53 ` Mark Lord
2009-11-13 0:25 ` Jeff Garzik
2009-11-13 0:41 ` Thiago Farina
2009-11-14 3:23 ` Mark Lord
2009-11-11 23:10 ` Jeff Garzik
2009-11-17 3:17 ` Jeff Garzik
2009-11-20 19:15 ` Thiago Farina
2009-11-20 22:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFB3C9D.4020609@rtr.ca \
--to=liml@rtr.ca \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=penberg@cs.helsinki.fi \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).