From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] ata: Clean up hard coded array size calculation. Date: Thu, 12 Nov 2009 18:53:16 -0500 Message-ID: <4AFC9FEC.8030304@rtr.ca> References: <1257708657-1232-1-git-send-email-tfransosi@gmail.com> <4AF8F363.3010806@rtr.ca> <200911101651.24912.bzolnier@gmail.com> <84144f020911100808y55f5bfa2v5c203b356583a7b5@mail.gmail.com> <4AFB3C9D.4020609@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:38947 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755762AbZKLXxN (ORCPT ); Thu, 12 Nov 2009 18:53:13 -0500 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Thiago Farina Cc: Pekka Enberg , Bartlomiej Zolnierkiewicz , jgarzik@pobox.com, mlord@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Thiago Farina wrote: > On Wed, Nov 11, 2009 at 8:37 PM, Mark Lord wrote: >> Looks like unnecessary churn and obfuscation to me. > > Obfuscation? Are you saying that just because you wrote this code? So > what is the usage of a macro? I think you are having a defensive > position here. .. No, actually I believe Jeff wrote that particular line of code. Cheers