From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: Thiago Farina <tfransosi@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
mlord@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: Clean up hard coded array size calculation.
Date: Thu, 12 Nov 2009 19:25:00 -0500 [thread overview]
Message-ID: <4AFCA75C.8000101@pobox.com> (raw)
In-Reply-To: <4AFC9FEC.8030304@rtr.ca>
On 11/12/2009 06:53 PM, Mark Lord wrote:
> Thiago Farina wrote:
>> On Wed, Nov 11, 2009 at 8:37 PM, Mark Lord <liml@rtr.ca> wrote:
>>> Looks like unnecessary churn and obfuscation to me.
>>
>> Obfuscation? Are you saying that just because you wrote this code? So
>> what is the usage of a macro? I think you are having a defensive
>> position here.
> ..
>
> No, actually I believe Jeff wrote that particular line of code.
You know, Linus actually invented a command for people who enjoy this
game... ;)
git blame drivers/ata/sata_mv.c
shows each line of code, and metadata about each line such as commit id
and author name.
Jeff
next prev parent reply other threads:[~2009-11-13 0:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 19:30 [PATCH] ata: Clean up hard coded array size calculation Thiago Farina
2009-11-08 19:45 ` Thiago Farina
2009-11-10 5:00 ` Mark Lord
2009-11-10 15:51 ` Bartlomiej Zolnierkiewicz
2009-11-10 16:08 ` Pekka Enberg
2009-11-11 22:37 ` Mark Lord
2009-11-11 22:50 ` Thiago Farina
2009-11-12 23:53 ` Mark Lord
2009-11-13 0:25 ` Jeff Garzik [this message]
2009-11-13 0:41 ` Thiago Farina
2009-11-14 3:23 ` Mark Lord
2009-11-11 23:10 ` Jeff Garzik
2009-11-17 3:17 ` Jeff Garzik
2009-11-20 19:15 ` Thiago Farina
2009-11-20 22:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFCA75C.8000101@pobox.com \
--to=jgarzik@pobox.com \
--cc=bzolnier@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=penberg@cs.helsinki.fi \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).