From: Mark Lord <liml@rtr.ca>
To: Thiago Farina <tfransosi@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
mlord@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: Clean up hard coded array size calculation.
Date: Fri, 13 Nov 2009 22:23:13 -0500 [thread overview]
Message-ID: <4AFE22A1.4050707@rtr.ca> (raw)
In-Reply-To: <a4c8a6d00911121641k13288cb3s696a876901c68eb3@mail.gmail.com>
Thiago Farina wrote:
> On Thu, Nov 12, 2009 at 10:25 PM, Jeff Garzik <jgarzik@pobox.com> wrote:
>> On 11/12/2009 06:53 PM, Mark Lord wrote:
>>> Thiago Farina wrote:
>>>> On Wed, Nov 11, 2009 at 8:37 PM, Mark Lord <liml@rtr.ca> wrote:
>>>>> Looks like unnecessary churn and obfuscation to me.
>>>> Obfuscation? Are you saying that just because you wrote this code? So
>>>> what is the usage of a macro? I think you are having a defensive
>>>> position here.
>>> ..
>>>
>>> No, actually I believe Jeff wrote that particular line of code.
>> You know, Linus actually invented a command for people who enjoy this
>> game... ;)
>>
>> git blame drivers/ata/sata_mv.c
>>
>> shows each line of code, and metadata about each line such as commit id and
>> author name.
>
> Sure, and I ran this command before saying that Mark wrote this code.
..
I'm probably just the last chap to change the indentation on it.
It really doesn't look like my style to me. ;)
There were two authors before me there, and that line looks like one of theirs. :)
Cheers
next prev parent reply other threads:[~2009-11-14 3:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 19:30 [PATCH] ata: Clean up hard coded array size calculation Thiago Farina
2009-11-08 19:45 ` Thiago Farina
2009-11-10 5:00 ` Mark Lord
2009-11-10 15:51 ` Bartlomiej Zolnierkiewicz
2009-11-10 16:08 ` Pekka Enberg
2009-11-11 22:37 ` Mark Lord
2009-11-11 22:50 ` Thiago Farina
2009-11-12 23:53 ` Mark Lord
2009-11-13 0:25 ` Jeff Garzik
2009-11-13 0:41 ` Thiago Farina
2009-11-14 3:23 ` Mark Lord [this message]
2009-11-11 23:10 ` Jeff Garzik
2009-11-17 3:17 ` Jeff Garzik
2009-11-20 19:15 ` Thiago Farina
2009-11-20 22:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFE22A1.4050707@rtr.ca \
--to=liml@rtr.ca \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=penberg@cs.helsinki.fi \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).