From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] ata: Clean up hard coded array size calculation. Date: Fri, 13 Nov 2009 22:23:13 -0500 Message-ID: <4AFE22A1.4050707@rtr.ca> References: <1257708657-1232-1-git-send-email-tfransosi@gmail.com> <4AF8F363.3010806@rtr.ca> <200911101651.24912.bzolnier@gmail.com> <84144f020911100808y55f5bfa2v5c203b356583a7b5@mail.gmail.com> <4AFB3C9D.4020609@rtr.ca> <4AFC9FEC.8030304@rtr.ca> <4AFCA75C.8000101@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:59533 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755260AbZKNDXJ (ORCPT ); Fri, 13 Nov 2009 22:23:09 -0500 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Thiago Farina Cc: Jeff Garzik , Pekka Enberg , Bartlomiej Zolnierkiewicz , mlord@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Thiago Farina wrote: > On Thu, Nov 12, 2009 at 10:25 PM, Jeff Garzik wrote: >> On 11/12/2009 06:53 PM, Mark Lord wrote: >>> Thiago Farina wrote: >>>> On Wed, Nov 11, 2009 at 8:37 PM, Mark Lord wrote: >>>>> Looks like unnecessary churn and obfuscation to me. >>>> Obfuscation? Are you saying that just because you wrote this code? So >>>> what is the usage of a macro? I think you are having a defensive >>>> position here. >>> .. >>> >>> No, actually I believe Jeff wrote that particular line of code. >> You know, Linus actually invented a command for people who enjoy this >> game... ;) >> >> git blame drivers/ata/sata_mv.c >> >> shows each line of code, and metadata about each line such as commit id and >> author name. > > Sure, and I ran this command before saying that Mark wrote this code. .. I'm probably just the last chap to change the indentation on it. It really doesn't look like my style to me. ;) There were two authors before me there, and that line looks like one of theirs. :) Cheers