linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	jgarzik@redhat.com, sean.hefty@intel.com,
	Arjan van de Ven <arjan@linux.intel.com>,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH]AHCI: disable sntf cap for ich8
Date: Mon, 16 Nov 2009 22:19:34 -0500	[thread overview]
Message-ID: <4B021646.5040102@garzik.org> (raw)
In-Reply-To: <20091116015605.GA21717@sli10-desk.sh.intel.com>

On 11/15/2009 08:56 PM, Shaohua Li wrote:
> I obseved there is a sata_async_notification() for every ahci interrupt. But the
> async notification does nothing (this is hard disk drive and no pmp). This cause
> cpu wastes some time on sntf register access.
>
> It appears ICH AHCI doesn't support SNotification register, but the controller
> reports it does. After quirking it, the async notification disappears.

Patch applied.


> PS. it appears all ICH don't support SNotification register from ICH manual, don't
> know if we need quirk all ICH. I don't have machines with all kinds of ICH.

You work for Intel -- you or somebody needs to research and figure this 
out...  This is an Intel vendor issue that only Intel can definitively 
resolve.

	Jeff



      reply	other threads:[~2009-11-17  3:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16  1:56 [PATCH]AHCI: disable sntf cap for ich8 Shaohua Li
2009-11-17  3:19 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B021646.5040102@garzik.org \
    --to=jeff@garzik.org \
    --cc=alan@linux.intel.com \
    --cc=arjan@linux.intel.com \
    --cc=jgarzik@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).