From: Mark Lord <liml@rtr.ca>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K. Petersen" <mkp@mkp.net>, Matthew Wilcox <willy@wil.cx>
Subject: Re: [PATCH] libata: add TRIM support
Date: Wed, 18 Nov 2009 22:35:29 -0500 [thread overview]
Message-ID: <4B04BD01.5090706@rtr.ca> (raw)
In-Reply-To: <20091117150012.GA10748@infradead.org>
Christoph Hellwig wrote:
> On Tue, Nov 17, 2009 at 02:52:39PM +0000, Alan Cox wrote:
>> I'm not convinced that is the right way to handle it. If we start doing
>> that we'll have this massive unmanagable set of magic flags and twiddles
>> for every possible host specific corner case.
>>
>> Far better to keep the issue of the command as Christoph has done and
>> block the command issue in the afflicted devices qc_issue so that you get
>> an error back. That keeps the mess in the right places.
>
> Ok, new version of the patch without this will go out this minute. I'm
> happy to add whatever patch is nessecary to block it for controllers
> that can't accept it once we agree on a method.
..
I imagine some sort of port or host flag, that the LLD could set
to indicate that it can correctly handle TRIM. Or not handle TRIM.
Tejun is pretty good at these flag things.. I wonder what he might suggest?
Cheers
next prev parent reply other threads:[~2009-11-19 3:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 15:43 [PATCH] libata: add TRIM support Christoph Hellwig
2009-11-16 16:07 ` Alan Cox
2009-11-16 16:19 ` Sergei Shtylyov
2009-11-17 14:30 ` Christoph Hellwig
2009-11-17 3:34 ` Jeff Garzik
2009-11-17 14:32 ` Christoph Hellwig
2009-11-17 21:59 ` Jeff Garzik
2009-11-17 14:36 ` Christoph Hellwig
2009-11-17 14:04 ` Mark Lord
2009-11-17 14:35 ` Christoph Hellwig
2009-11-17 14:52 ` Alan Cox
2009-11-17 15:00 ` Christoph Hellwig
2009-11-19 3:35 ` Mark Lord [this message]
2009-11-19 10:23 ` Alan Cox
2009-11-19 14:22 ` Mark Lord
[not found] ` <4B05DE00.3020707@gmail.com>
[not found] ` <20091120001829.354abfc0@lxorguk.ukuu.org.uk>
[not found] ` <4B05E3D1.1000904@pobox.com>
2009-11-20 12:46 ` Alan Cox
2009-11-21 4:33 ` Mark Lord
2009-11-21 6:09 ` Martin K. Petersen
2009-11-22 2:39 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B04BD01.5090706@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@mkp.net \
--cc=willy@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).