From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K. Petersen" <mkp@mkp.net>, Matthew Wilcox <willy@wil.cx>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH V2] libata: add TRIM support
Date: Wed, 18 Nov 2009 22:36:52 -0500 [thread overview]
Message-ID: <4B04BD54.7020203@rtr.ca> (raw)
In-Reply-To: <4B031D2F.7030004@pobox.com>
Jeff Garzik wrote:
> On 11/17/2009 10:00 AM, Christoph Hellwig wrote:
>> Add support for the ATA TRIM command in libata. We translate a WRITE
>> SAME 16
>> command with the unmap bit set into an ATA TRIM command and export enough
>> information in READ CAPACITY 16 and the block limits EVPD page so that
>> the new
>> SCSI layer discard support will driver this for us.
>>
>> Note that I hardcode the WRITE_SAME_16 opcode for now as the patch to
>> introduce
>> the symbolic is not in 2.6.32 yet but only in the SCSI tree - as soon
>> as it is
>> merged we can fix it up to properly use the symbolic name.
>>
>> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
> Looks good to me.... will apply to libata-dev.git#upstream soonish
..
Just make sure that no filesystem tries to use it by default.
The performance penalty from this is absolutely massive.
At least until the interface can do multiple trim ranges
per single trim command.
Cheers
next prev parent reply other threads:[~2009-11-19 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 15:00 [PATCH V2] libata: add TRIM support Christoph Hellwig
2009-11-17 22:01 ` Jeff Garzik
2009-11-19 3:36 ` Mark Lord [this message]
2009-11-19 23:46 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B04BD54.7020203@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@mkp.net \
--cc=willy@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).