From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 4/5] pata: Update experimental tags Date: Thu, 19 Nov 2009 17:38:38 +0300 Message-ID: <4B05586E.4080401@ru.mvista.com> References: <20091117144450.15430.83450.stgit@localhost.localdomain> <20091118184125.623e063d@lxorguk.ukuu.org.uk> <200911182007.07405.bzolnier@gmail.com> <200911182056.16517.bzolnier@gmail.com> <20091119140259.2fee86e2@lxorguk.ukuu.org.uk> <4B05533A.7020508@ru.mvista.com> <20091119143129.0fe41623@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gateway-1237.mvista.com ([206.112.117.35]:4913 "HELO imap.sh.mvista.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1752091AbZKSOhz (ORCPT ); Thu, 19 Nov 2009 09:37:55 -0500 In-Reply-To: <20091119143129.0fe41623@lxorguk.ukuu.org.uk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: Bartlomiej Zolnierkiewicz , Alan Cox , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Alan Cox wrote: >> Point out the breakage please. The driver has been developed and tested >>on non-x86 machine with 66 MHz PCI. > static int init_chipset_hpt366(struct pci_dev *dev) > > if (chip_type >= HPT370) { > > if ((temp & 0xFFFFF000) != 0xABCDE000) { > it then falls through and gets a 33MHz answer from the tests. > If I stash the MHz answer from boot then it works. So I imagine the boot > time value just needs to be dumped into a static for resume to use. Ah, that... sure, this test only works at boot if there was no smart enough BIOS around to save the f_CNT -- then the DPLL gets reprogrammed, and doesn't reflect the default clock anymore... > Alan WBR, Sergei