From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: Don't require newlines for link_power_management_policy
Date: Thu, 19 Nov 2009 16:30:50 -0500 [thread overview]
Message-ID: <4B05B90A.7090809@pobox.com> (raw)
In-Reply-To: <1258474143-3020-1-git-send-email-mjg@redhat.com>
On 11/17/2009 11:09 AM, Matthew Garrett wrote:
> sysfs attributes shouldn't require newlines. Make it possible to set the
> link power management policy without a trailing newline.
>
> Signed-off-by: Matthew Garrett<mjg@redhat.com>
> ---
> drivers/ata/libata-scsi.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index b4ee28d..512a3ee 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -154,8 +154,7 @@ static ssize_t ata_scsi_lpm_put(struct device *dev,
> */
> for (i = 1; i< ARRAY_SIZE(link_pm_policy); i++) {
> const int len = strlen(link_pm_policy[i].name);
> - if (strncmp(link_pm_policy[i].name, buf, len) == 0&&
> - buf[len] == '\n') {
> + if (strncmp(link_pm_policy[i].name, buf, len) == 0) {
> policy = link_pm_policy[i].value;
applied
prev parent reply other threads:[~2009-11-19 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 16:09 [PATCH] ata: Don't require newlines for link_power_management_policy Matthew Garrett
2009-11-19 21:30 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B05B90A.7090809@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).