From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 4/5] pata: Update experimental tags Date: Thu, 19 Nov 2009 16:38:39 -0500 Message-ID: <4B05BADF.1010205@garzik.org> References: <20091117144450.15430.83450.stgit@localhost.localdomain> <20091118184125.623e063d@lxorguk.ukuu.org.uk> <200911182007.07405.bzolnier@gmail.com> <200911182056.16517.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:59027 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754203AbZKSVig (ORCPT ); Thu, 19 Nov 2009 16:38:36 -0500 In-Reply-To: <200911182056.16517.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Alan Cox , Alan Cox , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On 11/18/2009 02:56 PM, Bartlomiej Zolnierkiewicz wrote: > On Wednesday 18 November 2009 20:07:07 Bartlomiej Zolnierkiewicz wrote: >> On Wednesday 18 November 2009 19:41:25 Alan Cox wrote: >>>> Maybe they are 'stable' but when it comes to features they are behind hpt366 >>>> (i.e. they lack PCI PM), which is also much cleaner than your drivers, easier >>>> to understand and much smaller.. >>> >>> 37x and 3xn lack PCI PM. Added to the TODO list. >>> >>> The smaller size is a bit questionable given its mostly comments, and >>> three drivers versus one. >> >> I wonder what you find 'questionable' in the numbers given.. > > BTW we can immediately reclaim 300 LOC by simply merging drivers back.. Merging drivers is a big pain for distributions and end users, even with the new module_alias facility. Absent stronger justification, libata remains with separate drivers, even if that means some code duplication. Jeff