From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Hemant Pedanekar <hemantp@ti.com>
Cc: linux-ide@vger.kernel.org, davem@davemloft.net,
bzolnier@gmail.com, petkovbb@gmail.com,
christian.engelmayer@frequentis.com,
linux-kernel@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] ide: fix ioctl to pass requested transfer mode to ide_find_dma_mode instead of UDMA6
Date: Tue, 24 Nov 2009 14:12:49 +0300 [thread overview]
Message-ID: <4B0BBFB1.20802@ru.mvista.com> (raw)
In-Reply-To: <1259036188-11598-1-git-send-email-hemantp@ti.com>
Hello.
Hemant Pedanekar wrote:
> Currently, ide_cmd_ioctl when invoked for setting DMA transfer mode calls
> ide_find_dma_mode with requested mode as XFER_UDMA_6. This prevents setting DMA
> mode to any other value than the default (maximum) supported by the device (or
> UDMA6, if supported) irrespective of the actual requested transfer mode and
> returns error.
>
> For example, setting mode to UDMA2 using hdparm, where UDMA4 is the default
> transfer mode gives following error:
> # ./hdparm -d1 -Xudma2 /dev/hda
> /dev/hda:hda: UDMA/66 mode selected
> setting using_dma to 1 (on)
> hda: UDMA/66 mode selected
> setting xfermode to 66 (UltraDMA mode2)
> HDIO_DRIVE_CMD(setxfermode) failed: Invalid argument
> using_dma = 1 (on)
>
> This patch fixes the issue.
>
> Signed-off-by: Hemant Pedanekar <hemantp@ti.com>
> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
next prev parent reply other threads:[~2009-11-24 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 4:16 [PATCH] ide: fix ioctl to pass requested transfer mode to ide_find_dma_mode instead of UDMA6 Hemant Pedanekar
2009-11-24 11:12 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-24 11:50 Hemant Pedanekar
2009-11-25 23:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0BBFB1.20802@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=christian.engelmayer@frequentis.com \
--cc=davem@davemloft.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hemantp@ti.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).