From: Robert Hancock <hancockrwd@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: libata PM question
Date: Sun, 29 Nov 2009 21:53:19 -0600 [thread overview]
Message-ID: <4B1341AF.2000208@gmail.com> (raw)
In-Reply-To: <1259552541.2076.56.camel@pasglop>
On 11/29/2009 09:42 PM, Benjamin Herrenschmidt wrote:
> On Mon, 2009-11-30 at 13:25 +1100, Benjamin Herrenschmidt wrote:
>> On Mon, 2009-11-30 at 13:22 +1100, Benjamin Herrenschmidt wrote:
>>> Hi there !
>>>
>>> So I (finally !) resumed work on pata_macio.c to replace ide/pmac.c :-)
>>>
>>> I've started looking at the suspend/resume stuff. It looks like most of
>>> it just comes for free thanks to libata, yay ! :-)
>>
>> .../...
>>
>> Oh, another question... where do we spin the disk down& park it on
>> suspend ? I'm missed at least that part :-)
>
> Oh and finally, one last question for today ...
>
> In drivers/ide, we have a call to ledtrig_ide_activity() inside
> ide_do_rw_disk() which allows me to flash the front light on
> the powerbook.
>
> libata has no such thing.
>
> It's as simple as adding that call, if we want to keep the trigger named
> "ide-disk" but where to put it then ? In ata_scsi_rw_xlat() ? Yuck :-)
>
> Another option is to stick it in drivers/scsi/sd.c but the trigger
> should not be named ide-disk anymore ... Also it will start tiggering
> for any "pseudo scsi" device in the machine which is note quite the
> purpose... It would be nice if it really only triggered on libata and as
> such blink the led only for the internal HD on those powerbooks (unless
> you have some libata based PCMCIA stuff but that doesn't matter).
>
> Anyway, nothing fancy, just a quick hack to get the activity led
> back :-) I could always stick it somewhere in pata_macio.c but that
> would suck probably even more.
Looks like the only libata driver that currently does LED blinking is
ahci (for external enclosures) and it's just handled there using
qc_issue plus a timer. Most drivers don't need this and given that you
need to do it only for specific devices and only your driver has that
knowledge, I don't see much problem with just sticking the LED trigger
call into your qc_issue or something similar. No sense in trying to make
something generic if it's not generic..
next prev parent reply other threads:[~2009-11-30 3:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 2:22 libata PM question Benjamin Herrenschmidt
2009-11-30 2:25 ` Benjamin Herrenschmidt
2009-11-30 3:42 ` Benjamin Herrenschmidt
2009-11-30 3:53 ` Robert Hancock [this message]
2009-11-30 5:51 ` Benjamin Herrenschmidt
2009-11-30 3:47 ` Robert Hancock
2009-11-30 7:26 ` Tejun Heo
2009-11-30 7:32 ` Shaohua Li
2009-11-30 7:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1341AF.2000208@gmail.com \
--to=hancockrwd@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).