From: Tejun Heo <tj@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
Shaohua Li <shaohua.li@intel.com>
Subject: Re: libata PM question
Date: Mon, 30 Nov 2009 16:26:54 +0900 [thread overview]
Message-ID: <4B1373BE.3000709@kernel.org> (raw)
In-Reply-To: <1259547765.2076.48.camel@pasglop>
(Shaohua Li cc'd)
Hello,
On 11/30/2009 11:22 AM, Benjamin Herrenschmidt wrote:
> One quick nit tho, in libata-eh.c, in ata_eh_handle_port_suspend(), any
> reason why you always call ata_acpi_set_state(ap, PMSG_SUSPEND) rather
> than ata_acpi_set_state(ap, ap->pm_mesg) ?
>
> Not directly related to my pmac driver but it seems like it would cause
> calls into ACPI suspend/resume code even when doing freeze/thaw for
> hibernation which doesn't sound totally right to me ... or do I miss
> something ?
Indeed, it looks like it will power down the IDE port over freeze.
Shaohua, this is added by commit
bd3adca52bc43b72c75db3e4c7809d47923b154c. Skipping power down on
freeze is probably the right thing to do?
Thanks.
--
tejun
next prev parent reply other threads:[~2009-11-30 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 2:22 libata PM question Benjamin Herrenschmidt
2009-11-30 2:25 ` Benjamin Herrenschmidt
2009-11-30 3:42 ` Benjamin Herrenschmidt
2009-11-30 3:53 ` Robert Hancock
2009-11-30 5:51 ` Benjamin Herrenschmidt
2009-11-30 3:47 ` Robert Hancock
2009-11-30 7:26 ` Tejun Heo [this message]
2009-11-30 7:32 ` Shaohua Li
2009-11-30 7:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1373BE.3000709@kernel.org \
--to=tj@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).