From: Tejun Heo <tj@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: libata hotplug question
Date: Tue, 01 Dec 2009 14:34:08 +0900 [thread overview]
Message-ID: <4B14AAD0.4060806@kernel.org> (raw)
In-Reply-To: <1259645409.2076.213.camel@pasglop>
On 12/01/2009 02:30 PM, Benjamin Herrenschmidt wrote:
>> You didn't schedule any EH actions, right?
>
> I did the usual ehi_hotplug + freeze
Hmmm.... then I have no idea what happened there. :-(
>> libata-acpi.c does that. Setting ATA_DFLAG_DETACH device flag and
>> scheduling EH will do that. Please take a look at
>> ata_acpi_detach_device() but you must be *sure* that your hot unplug
>> notification is completely reliable.
>
> Well, it seems to be reliable that way for unplugs. I even debounce it
> both ways but I'm actually considering removing the debounce on unplug.
>
> I'll let you know how it goes with a custom prereset() that returns
> -ENODEV. How would that differ from ATA_DFLAG_DETACH ?
In effect, they would be the same but if the hotplug notification can
be made reliable, I think using DFLAG_DETACH would be better as
there's already other users doing that (user requested detach and ACPI
dock removal).
Thanks.
--
tejun
next prev parent reply other threads:[~2009-12-01 5:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 6:04 libata hotplug question Benjamin Herrenschmidt
2009-11-30 23:44 ` Benjamin Herrenschmidt
2009-11-30 23:48 ` Tejun Heo
2009-12-01 0:05 ` Benjamin Herrenschmidt
2009-12-01 2:43 ` Benjamin Herrenschmidt
2009-12-01 4:51 ` Tejun Heo
2009-12-01 5:24 ` Benjamin Herrenschmidt
2009-12-01 5:17 ` Benjamin Herrenschmidt
2009-12-01 5:22 ` Tejun Heo
2009-12-01 5:30 ` Benjamin Herrenschmidt
2009-12-01 5:34 ` Tejun Heo [this message]
2009-12-01 5:39 ` Benjamin Herrenschmidt
2009-12-01 5:57 ` Benjamin Herrenschmidt
2009-12-01 5:35 ` Benjamin Herrenschmidt
2009-11-30 23:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B14AAD0.4060806@kernel.org \
--to=tj@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).