From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop() Date: Tue, 01 Dec 2009 16:33:43 +0900 Message-ID: <4B14C6D7.3030303@kernel.org> References: <20091201070833.CC084B7BD9@ozlabs.org> <4B14C4DC.6060107@kernel.org> <1259652545.2076.321.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:37357 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359AbZLAHdg (ORCPT ); Tue, 1 Dec 2009 02:33:36 -0500 In-Reply-To: <1259652545.2076.321.camel@pasglop> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Benjamin Herrenschmidt Cc: linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, jeff@garzik.org On 12/01/2009 04:29 PM, Benjamin Herrenschmidt wrote: > On Tue, 2009-12-01 at 16:25 +0900, Tejun Heo wrote: >> On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote: >>> In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() >>> instead of ap->ops->bmdma_stop(). This can be a problem for controllers >>> that use their own bmdma_stop for which the generic sff one isn't suitable >>> >>> Signed-off-by: Benjamin Herrenschmidt >> >> Oh... that's a scary bug lurking around. Thanks for catching it. >> >> Acked-by: Tejun Heo > > Feel free to pick that one up earlier if you want (ie for 2.6.32), as > long as we manage to get it in in 2.6.33 -before- I push powerpc-next to > Linus, I'm happy :-) (or we can have it in both trees). As nasty as the bug might be, given that we haven't had too much problem with that, I think it would be best to give it some time to be tested before releasing it to users. It causes behavior differences for all bmdma drivers which implement custom bmdma_stop. It's an apparent bug fix but well the nasty ones are always apparent bug fixes, right? :-) Thanks. -- tejun