From: Jeff Garzik <jgarzik@pobox.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mark Lord <kernel@teksavvy.com>,
jens.axboe@oracle.com, james.bottomley@hansenpartnership.com,
hch@infradead.org, willy@wil.cx, sandeen@redhat.com,
rwheeler@redhat.com, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/5] libata: Report zeroed read after Trim and max discard size
Date: Thu, 03 Dec 2009 02:57:54 -0500 [thread overview]
Message-ID: <4B176F82.4050907@pobox.com> (raw)
In-Reply-To: <yq18wds3a10.fsf@sermon.lab.mkp.net>
On 11/26/2009 10:46 PM, Martin K. Petersen wrote:
>>>>>> "Mark" == Mark Lord<kernel@teksavvy.com> writes:
>
> Mark> Is that correct, or should it be this:
>
> Mark> if (ata_id_has_trim(id)&& (id[ATA_ID_ADDITIONAL_SUPP]&
> Mark> 0x4020) == 0x4020)
>
> Good spotting! You are right, I need both bits to be set...
>
>
> libata: Report zeroed read after Trim and max discard size
>
> Our current Trim payload is a single sector that can accommodate 64 *
> 65535 blocks being unmapped. Report this value in the Block Limits
> Maximum Unmap LBA count field.
>
> If a storage device supports Trim and the DRAT and RZAT bits are set,
> report TPRZ=1 in Read Capacity(16).
>
> Signed-off-by: Martin K. Petersen<martin.petersen@oracle.com>
The two libata patches look good. I need to review the thread one more
time, and then will apply these...
next prev parent reply other threads:[~2009-12-03 7:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 17:00 Thin provisioning fixes (take 3) Martin K. Petersen
2009-11-26 17:00 ` [PATCH 1/5] block: Allow devices to indicate whether discarded blocks are zeroed Martin K. Petersen
2009-11-26 17:00 ` [PATCH 2/5] sd: WRITE SAME(16) / UNMAP support Martin K. Petersen
2009-11-26 17:00 ` [PATCH 3/5] scsi: Correctly handle thin provisioning write error Martin K. Petersen
2009-11-26 17:00 ` [PATCH 4/5] libata: Report zeroed read after Trim and max discard size Martin K. Petersen
2009-11-27 1:55 ` Mark Lord
2009-11-27 3:46 ` Martin K. Petersen
2009-12-03 7:57 ` Jeff Garzik [this message]
2009-12-03 23:02 ` Jeff Garzik
2009-11-26 17:00 ` [PATCH 5/5] libata: Clarify ata_set_lba_range_entries function Martin K. Petersen
2009-12-03 23:02 ` Jeff Garzik
2009-11-26 17:09 ` Thin provisioning fixes (take 3) James Bottomley
2009-11-26 17:27 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B176F82.4050907@pobox.com \
--to=jgarzik@pobox.com \
--cc=hch@infradead.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=jens.axboe@oracle.com \
--cc=kernel@teksavvy.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
--cc=willy@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).