From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@linux.intel.com>
Cc: linux-ide@vger.kernel.org, jeff@garzik.org, davem@davemloft.net
Subject: Re: [PATCH 2/6] pata_sis: Implement MWDMA for the UDMA 133 capable chips
Date: Mon, 07 Dec 2009 16:26:00 +0300 [thread overview]
Message-ID: <4B1D0268.4090508@ru.mvista.com> (raw)
In-Reply-To: <20091130132248.27236.35287.stgit@localhost.localdomain>
Hello.
Alan Cox wrote:
> Bartlomiej pointed out that while this got fixed in the old driver whoever
> did it didn't port it across.
> Signed-off-by: Alan Cox <alan@linux.intel.com>
[...]
> +static int mwdma_clip_to_pio(struct ata_device *adev)
> +{
> + const int mwdma_to_pio[3] = {
> + XFER_PIO_0, XFER_PIO_3, XFER_PIO_4
> + };
> + return min(mwdma_to_pio[adev->dma_mode - XFER_MW_DMA_0],
> + adev->pio_mode - XFER_PIO_0);
> +}
You call min() on uncomparables, i.e. mwdma_to_pio[] contains XFER_PIO_*
and adev->pio_mode - XFER_PIO_0 yields you a mode number. Thus the second
argument will always "win" as a minimal one.
MBR, Sergei
next prev parent reply other threads:[~2009-12-07 13:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 13:22 [PATCH 0/6] ATA driver updates Alan Cox
2009-11-30 13:22 ` [PATCH 1/6] pata_via: Blacklist some combinations of Transcend Flash and via Alan Cox
2009-11-30 13:22 ` [PATCH 2/6] pata_sis: Implement MWDMA for the UDMA 133 capable chips Alan Cox
2009-12-07 13:26 ` Sergei Shtylyov [this message]
2009-12-07 15:05 ` Bartlomiej Zolnierkiewicz
2009-12-07 15:11 ` Bartlomiej Zolnierkiewicz
2009-12-07 15:36 ` Bartlomiej Zolnierkiewicz
2009-12-07 15:53 ` Bartlomiej Zolnierkiewicz
2009-12-07 16:34 ` Bartlomiej Zolnierkiewicz
2009-12-07 17:53 ` Alan Cox
2009-12-07 18:36 ` Bartlomiej Zolnierkiewicz
2009-11-30 13:22 ` [PATCH 3/6] cmd64x: implement serialization as per notes Alan Cox
2009-11-30 13:23 ` [PATCH 4/6] pata: Update experimental tags Alan Cox
2009-11-30 13:23 ` [PATCH 5/6] pata_ali: Fix regression with old devices Alan Cox
2009-11-30 13:23 ` [PATCH 6/6] pata_piccolo: Driver for old Toshiba chipsets Alan Cox
2009-12-03 7:36 ` Jeff Garzik
2009-12-03 9:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1D0268.4090508@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).