From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 2/2] pata_cs5520: use ATA_DMA_* constants
Date: Thu, 17 Dec 2009 01:20:46 -0500 [thread overview]
Message-ID: <4B29CDBE.8040008@pobox.com> (raw)
In-Reply-To: <200912042339.00746.sshtylyov@ru.mvista.com>
On 12/04/2009 03:39 PM, Sergei Shtylyov wrote:
> Use ATA_DMA_* constants instead of the bare numbers for the BMIDE registers.
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree.
>
> drivers/ata/pata_cs5520.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-2.6/drivers/ata/pata_cs5520.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_cs5520.c
> +++ linux-2.6/drivers/ata/pata_cs5520.c
> @@ -99,9 +99,9 @@ static void cs5520_set_timings(struct at
> static void cs5520_enable_dma(struct ata_port *ap, struct ata_device *adev)
> {
> /* Set the DMA enable/disable flag */
> - u8 reg = ioread8(ap->ioaddr.bmdma_addr + 0x02);
> - reg |= 1<<(adev->devno + 5);
> - iowrite8(reg, ap->ioaddr.bmdma_addr + 0x02);
> + u8 reg = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
> + reg |= 1<< (adev->devno + 5);
> + iowrite8(reg, ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
> }
skipped -- Bart's patch (940a68de56c1952c29d9f3c1a769a82b1bdd2b67)
superceded this
prev parent reply other threads:[~2009-12-17 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 20:39 [PATCH 2/2] pata_cs5520: use ATA_DMA_* constants Sergei Shtylyov
2009-12-04 23:26 ` Alan Cox
2009-12-17 6:20 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B29CDBE.8040008@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).