* [PATCH 2/2] pata_cs5520: use ATA_DMA_* constants
@ 2009-12-04 20:39 Sergei Shtylyov
2009-12-04 23:26 ` Alan Cox
2009-12-17 6:20 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2009-12-04 20:39 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide, alan
Use ATA_DMA_* constants instead of the bare numbers for the BMIDE registers.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
drivers/ata/pata_cs5520.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/ata/pata_cs5520.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_cs5520.c
+++ linux-2.6/drivers/ata/pata_cs5520.c
@@ -99,9 +99,9 @@ static void cs5520_set_timings(struct at
static void cs5520_enable_dma(struct ata_port *ap, struct ata_device *adev)
{
/* Set the DMA enable/disable flag */
- u8 reg = ioread8(ap->ioaddr.bmdma_addr + 0x02);
- reg |= 1<<(adev->devno + 5);
- iowrite8(reg, ap->ioaddr.bmdma_addr + 0x02);
+ u8 reg = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
+ reg |= 1 << (adev->devno + 5);
+ iowrite8(reg, ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
}
/**
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] pata_cs5520: use ATA_DMA_* constants
2009-12-04 20:39 [PATCH 2/2] pata_cs5520: use ATA_DMA_* constants Sergei Shtylyov
@ 2009-12-04 23:26 ` Alan Cox
2009-12-17 6:20 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2009-12-04 23:26 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: jgarzik, linux-ide
On Sat, 5 Dec 2009 00:39:00 +0400
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> Use ATA_DMA_* constants instead of the bare numbers for the BMIDE registers.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
If we are dropping out the virtual DMA support as Bartlomiej proposed
that bit can go completely.
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] pata_cs5520: use ATA_DMA_* constants
2009-12-04 20:39 [PATCH 2/2] pata_cs5520: use ATA_DMA_* constants Sergei Shtylyov
2009-12-04 23:26 ` Alan Cox
@ 2009-12-17 6:20 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2009-12-17 6:20 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, alan
On 12/04/2009 03:39 PM, Sergei Shtylyov wrote:
> Use ATA_DMA_* constants instead of the bare numbers for the BMIDE registers.
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree.
>
> drivers/ata/pata_cs5520.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-2.6/drivers/ata/pata_cs5520.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_cs5520.c
> +++ linux-2.6/drivers/ata/pata_cs5520.c
> @@ -99,9 +99,9 @@ static void cs5520_set_timings(struct at
> static void cs5520_enable_dma(struct ata_port *ap, struct ata_device *adev)
> {
> /* Set the DMA enable/disable flag */
> - u8 reg = ioread8(ap->ioaddr.bmdma_addr + 0x02);
> - reg |= 1<<(adev->devno + 5);
> - iowrite8(reg, ap->ioaddr.bmdma_addr + 0x02);
> + u8 reg = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
> + reg |= 1<< (adev->devno + 5);
> + iowrite8(reg, ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
> }
skipped -- Bart's patch (940a68de56c1952c29d9f3c1a769a82b1bdd2b67)
superceded this
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-17 6:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-04 20:39 [PATCH 2/2] pata_cs5520: use ATA_DMA_* constants Sergei Shtylyov
2009-12-04 23:26 ` Alan Cox
2009-12-17 6:20 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).