Re: [PATCH #upstream, v4] ahci: Implement SATA AHCI FIS-based switching support

[Jeff Garzik <jgarzik@pobox.com>]

On 12/09/2009 04:23 AM, Shane Huang wrote:
> Implement SATA AHCI FIS-based switching support.
>
> Tested on AMD internal reference board.
>
> Signed-off-by: Shane Huang<shane.huang@amd.com>
> Cc: Tejun Heo<tj@kernel.org>
> ---
> Changes from the last version(v3):
> * Rediff for the current upstream kernel as Jeff Garzik asked.
>
> Changes from v2:
> * Move fbs_need_dec from struct ahci_port_priv to ahci_error_intr() as
>    a local variable.
> * Add BUG_ON(!pp->fbs_enabled) for ahci_fbs_dec_intr().
> * Refine the retry loop in ahci_fbs_dec_intr().
> * Refine the code to determine failed active link with ap->pmp_link in
>    ahci_error_intr().
> * WARN_ON() in ahci_port_intr() can storm the machine with consecutive
>    stack dumps, replace it with WARN_ON_ONCE().
> * Refine ahci_enable_fbs()/ahci_disable_fbs(), and discard the message
>    for controllers which do not support FBS.
> * Add a warning message in ahci_port_start() for those weird controllers
>    which support CAP.FBSS but do not support PxCMD.FBSCP.
> * Several small corrections for better coding style.

applied...  nice work, thanks!