linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Hancock <hancockrwd@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <tj@kernel.org>,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	"Zhao, Richard" <Richard.Zhao@amd.com>,
	shane.huang@amd.com
Subject: Re: [PATCH RFC] ahci: implement handoff quirk
Date: Thu, 17 Dec 2009 21:54:30 -0600	[thread overview]
Message-ID: <4B2AFCF6.5030602@gmail.com> (raw)
In-Reply-To: <4B29D0FA.6060805@garzik.org>

On 12/17/2009 12:34 AM, Jeff Garzik wrote:
> On 06/17/2008 11:37 PM, Tejun Heo wrote:
>> ahci 1.2 has an exciting! new feature called BIOS/OS handoff which
>> basically is there to allow BIOS to keep tinkering with the controller
>> even after OS starts executing. I have no idea what this is useful
>> for but it's there and we need to do it.
>>
>> This patch implements the handoff as FIXUP_HEADER as the controller
>> needs to be claimed before the OS changes any configuration including
>> IRQ routing.
>>
>> I'm yet to see any controller which actually requires this, so it's
>> not for inclusion yet. Maybe keep this in a separate branch?
>>
>> RFC, DON'T COMMIT
>> ---
>> drivers/pci/quirks.c | 109
>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 109 insertions(+)
>
> Looking through old emails... did AMD ever confirm the usefulness of
> this patch? Is it actually needed in the field? I'm guessing the silence
> implies "No"... :)

Well, we only implemented the feature bit displaying for the BOH 
"capability" recently, so I guess we wouldn't likely have seen it if 
something did advertise it. However, it's true I don't know why any sane 
BIOS would want to do this. Can't hurt to have the support, however..

      reply	other threads:[~2009-12-18  3:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18  3:37 [PATCH RFC] ahci: implement handoff quirk Tejun Heo
2009-04-11 16:54 ` Jeff Garzik
2009-04-11 17:51   ` Tejun Heo
2009-04-11 18:02     ` Jeff Garzik
2009-04-14  9:16       ` Tejun Heo
2009-04-14  9:41         ` Jeff Garzik
2009-04-15  1:54           ` Huang, Shane
2009-12-17  6:34 ` Jeff Garzik
2009-12-18  3:54   ` Robert Hancock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2AFCF6.5030602@gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=Richard.Zhao@amd.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=shane.huang@amd.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).