From: Robert Hancock <hancockrwd@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Torsten Kaiser <just.for.lkml@googlemail.com>,
linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org
Subject: Re: MSI broken in libata?
Date: Sun, 10 Jan 2010 19:39:38 -0600 [thread overview]
Message-ID: <4B4A815A.60503@gmail.com> (raw)
In-Reply-To: <4B4A7BC7.6060106@kernel.org>
On 01/10/2010 07:15 PM, Tejun Heo wrote:
> On 01/10/2010 01:33 PM, Torsten Kaiser wrote:
>> I did try the patch from Robert Hancock in
>> http://lkml.org/lkml/2010/1/6/417 ,but without success.
>>
>> if you need any more information, or have something for me to try,
>> please just ask. I did look at the code and the documentation about
>> enabling MSI, but did not see anything (obvious) wrong, so I don't
>> know what to try next.
>
> Can you please try the attached patch?
>
> Thanks.
>
It'd be interesting to see if it makes a difference, but I don't think
the patch is quite right. According to the datasheet, doing the MSI ack
while the interrupt source is still pending will cause a new MSI to be
sent, so if you do it before handling the interrupt you'll generate a
spurious interrupt after every real one.
Though, apparently my patch that did the MSI ack after the handling
didn't help, so either that's wrong or the problem is unrelated. (I tend
to suspect the latter, given that sata_nv is also failing in the same way.)
next prev parent reply other threads:[~2010-01-11 1:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-25 9:22 MSI broken in libata? Torsten Kaiser
2010-01-09 9:11 ` Tejun Heo
2010-01-10 4:33 ` Torsten Kaiser
2010-01-11 1:15 ` Tejun Heo
2010-01-11 1:39 ` Robert Hancock [this message]
2010-01-11 2:17 ` Tejun Heo
2010-01-16 21:58 ` Torsten Kaiser
2010-01-17 19:22 ` Robert Hancock
2010-01-17 21:11 ` Torsten Kaiser
2010-01-18 20:51 ` Torsten Kaiser
2010-01-19 2:03 ` Robert Hancock
2010-01-19 7:00 ` Torsten Kaiser
2010-01-19 20:20 ` Torsten Kaiser
2010-01-20 3:00 ` Robert Hancock
2010-01-20 6:48 ` Torsten Kaiser
2010-01-22 0:53 ` Robert Hancock
2010-01-11 6:44 ` Torsten Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4A815A.60503@gmail.com \
--to=hancockrwd@gmail.com \
--cc=jgarzik@pobox.com \
--cc=just.for.lkml@googlemail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).