From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Jeff Garzik <jeff@garzik.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Hans Werner <hwerner4@gmx.de>
Subject: Re: [PATCH #upstream-fixes 1/2] libata: cleanup ata_sff_interrupt()
Date: Fri, 15 Jan 2010 12:36:08 +0900 [thread overview]
Message-ID: <4B4FE2A8.3070002@kernel.org> (raw)
In-Reply-To: <4B4EEFF9.8060805@ru.mvista.com>
On 01/14/2010 07:20 PM, Sergei Shtylyov wrote:
>> + qc = ata_qc_from_tag(ap, ap->link.active_tag);
>> + if (qc && (!(qc->tf.flags & ATA_TFLAG_POLLING)))
>>
>
> () not needed around !x.
Eh... I don't know. I personally prefer using minimum number of
parantheses but quite a few people dislike not using them when && & ||
| are mixed. In the end, I don't think it really matters. It's like
debating about how far the second part of a broken line should be
indented. Many people strong opinions but in the end it doesn't
really matter. Anyhow, if it bothers you enough to write an email
about it, I'll be happy to oblige. :-)
Thanks.
--
tejun
next prev parent reply other threads:[~2010-01-15 3:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 7:50 [PATCH #upstream-fixes 1/2] libata: cleanup ata_sff_interrupt() Tejun Heo
2010-01-14 7:53 ` [PATCH #upstream-fixes 2/2] libata: implement spurious irq handling for SFF and apply it to piix Tejun Heo
2010-01-14 12:42 ` Sergei Shtylyov
2010-01-15 3:39 ` Tejun Heo
2010-01-15 10:23 ` Sergei Shtylyov
2010-01-15 21:45 ` Tejun Heo
2010-01-14 10:20 ` [PATCH #upstream-fixes 1/2] libata: cleanup ata_sff_interrupt() Sergei Shtylyov
2010-01-15 3:36 ` Tejun Heo [this message]
2010-01-14 17:38 ` Jeff Garzik
2010-01-15 3:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4FE2A8.3070002@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hwerner4@gmx.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).