* [PATCH] libata: make functions/variables static
@ 2010-01-20 5:03 Robert Hancock
2010-01-20 19:33 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Robert Hancock @ 2010-01-20 5:03 UTC (permalink / raw)
To: ide, Jeff Garzik
Make some variables in ahci and a function in pata_pcmcia static, as found
using sparse.
Signed-off-by: Robert Hancock <hancockrwd@gmail.com>
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index b8bea10..265d0d4 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -356,10 +356,10 @@ static ssize_t ahci_show_host_version(struct device *dev,
static ssize_t ahci_show_port_cmd(struct device *dev,
struct device_attribute *attr, char *buf);
-DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL);
-DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL);
-DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL);
-DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL);
+static DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL);
+static DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL);
+static DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL);
+static DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL);
static struct device_attribute *ahci_shost_attrs[] = {
&dev_attr_link_power_management_policy,
diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
index 1b392c9..3610353 100644
--- a/drivers/ata/pata_pcmcia.c
+++ b/drivers/ata/pata_pcmcia.c
@@ -136,7 +136,7 @@ static unsigned int ata_data_xfer_8bit(struct ata_device *dev,
*
*/
-void pcmcia_8bit_drain_fifo(struct ata_queued_cmd *qc)
+static void pcmcia_8bit_drain_fifo(struct ata_queued_cmd *qc)
{
int count;
struct ata_port *ap;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] libata: make functions/variables static
2010-01-20 5:03 [PATCH] libata: make functions/variables static Robert Hancock
@ 2010-01-20 19:33 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2010-01-20 19:33 UTC (permalink / raw)
To: Robert Hancock; +Cc: ide
On 01/20/2010 12:03 AM, Robert Hancock wrote:
> Make some variables in ahci and a function in pata_pcmcia static, as found
> using sparse.
>
> Signed-off-by: Robert Hancock<hancockrwd@gmail.com>
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index b8bea10..265d0d4 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -356,10 +356,10 @@ static ssize_t ahci_show_host_version(struct device *dev,
> static ssize_t ahci_show_port_cmd(struct device *dev,
> struct device_attribute *attr, char *buf);
>
> -DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL);
> -DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL);
> -DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL);
> -DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL);
> +static DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL);
> +static DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL);
> +static DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL);
> +static DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL);
>
> static struct device_attribute *ahci_shost_attrs[] = {
> &dev_attr_link_power_management_policy,
> diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
> index 1b392c9..3610353 100644
> --- a/drivers/ata/pata_pcmcia.c
> +++ b/drivers/ata/pata_pcmcia.c
> @@ -136,7 +136,7 @@ static unsigned int ata_data_xfer_8bit(struct ata_device *dev,
> *
> */
>
> -void pcmcia_8bit_drain_fifo(struct ata_queued_cmd *qc)
> +static void pcmcia_8bit_drain_fifo(struct ata_queued_cmd *qc)
> {
> int count;
> struct ata_port *ap;
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-20 19:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 5:03 [PATCH] libata: make functions/variables static Robert Hancock
2010-01-20 19:33 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).