From: Tejun Heo <htejun@gmail.com>
To: Bart Hartgers <bart.hartgers@gmail.com>
Cc: Robert Hancock <hancockrwd@gmail.com>,
linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, juergen.metzdorf@telelev-dsl.de,
markpschool@hotmail.com, sporadic.crash@gmail.com,
apopov@sirma.bg, david@coomber.co.za, jay4mail@gmail.com
Subject: Re: [patch 2/2] sata_via: Delay on vt6420 when starting ATAPI DMA write
Date: Wed, 20 Jan 2010 15:54:24 +0900 [thread overview]
Message-ID: <4B56A8A0.3050309@gmail.com> (raw)
In-Reply-To: <7eb6a4d81001192233i5418249ct5a1717045f75167c@mail.gmail.com>
Hello,
On 01/20/2010 03:33 PM, Bart Hartgers wrote:
> Well, the ata_sff_pause actually does a ndelay(400), and with today's
> processors that would be a 'slow path', right?
unlikely() is used to mark very unlikely paths not the slow ones and I
don't really think DMA_TO_DEVICE would qualify as an unlikely path.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-01-20 6:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 23:56 [patch 0/2] sata_via: bugfixes for vt6420 and vt6421 Bart Hartgers
2010-01-16 23:56 ` [patch 1/2] sata_via: Correctly setup PIO/DMA for pata slave on vt6421 Bart Hartgers
2010-01-20 3:33 ` Tejun Heo
2010-01-20 19:35 ` Jeff Garzik
2010-01-16 23:56 ` [patch 2/2] sata_via: Delay on vt6420 when starting ATAPI DMA write Bart Hartgers
2010-01-20 3:30 ` Tejun Heo
2010-01-20 4:53 ` Robert Hancock
2010-01-20 6:33 ` Bart Hartgers
2010-01-20 6:54 ` Tejun Heo [this message]
2010-01-20 10:43 ` Bart Hartgers
2010-01-20 6:44 ` Bart Hartgers
2010-01-20 6:55 ` Tejun Heo
2010-02-13 22:47 ` Jeff Garzik
2010-02-14 11:20 ` Bart Hartgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B56A8A0.3050309@gmail.com \
--to=htejun@gmail.com \
--cc=apopov@sirma.bg \
--cc=bart.hartgers@gmail.com \
--cc=david@coomber.co.za \
--cc=hancockrwd@gmail.com \
--cc=jay4mail@gmail.com \
--cc=jgarzik@pobox.com \
--cc=juergen.metzdorf@telelev-dsl.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markpschool@hotmail.com \
--cc=sporadic.crash@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).