From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Hans Werner <hwerner4@gmx.de>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH #upstream 1/2] libata: cleanup ata_sff_interrupt()
Date: Wed, 20 Jan 2010 14:29:00 -0500 [thread overview]
Message-ID: <4B57597C.8000309@garzik.org> (raw)
In-Reply-To: <4B550EF8.1000009@kernel.org>
On 01/18/2010 08:46 PM, Tejun Heo wrote:
> host->ports[i] is never NULL if i< host->n_ports and non-NULL return
> from ata_qc_from_tag() guarantees that the returned qc is active.
> Drop unnecessary tests.
>
> Superflous () dropped as suggested by Sergei.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Cc: Sergei Shtylyov<sshtylyov@ru.mvista.com>
> ---
> drivers/ata/libata-sff.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
applied
prev parent reply other threads:[~2010-01-20 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 1:46 [PATCH #upstream 1/2] libata: cleanup ata_sff_interrupt() Tejun Heo
2010-01-19 1:49 ` [PATCH #upstream 2/2] libata: implement spurious irq handling for SFF and apply it to piix Tejun Heo
2010-01-20 19:33 ` Jeff Garzik
2010-01-20 23:45 ` Tejun Heo
2010-01-21 12:14 ` Alan Cox
2010-01-21 16:52 ` Jeff Garzik
2010-01-22 0:36 ` Tejun Heo
2010-01-20 19:29 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B57597C.8000309@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hwerner4@gmx.de \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).