From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata: make functions/variables static
Date: Wed, 20 Jan 2010 14:33:33 -0500 [thread overview]
Message-ID: <4B575A8D.8010908@garzik.org> (raw)
In-Reply-To: <4B568EAB.1030207@gmail.com>
On 01/20/2010 12:03 AM, Robert Hancock wrote:
> Make some variables in ahci and a function in pata_pcmcia static, as found
> using sparse.
>
> Signed-off-by: Robert Hancock<hancockrwd@gmail.com>
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index b8bea10..265d0d4 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -356,10 +356,10 @@ static ssize_t ahci_show_host_version(struct device *dev,
> static ssize_t ahci_show_port_cmd(struct device *dev,
> struct device_attribute *attr, char *buf);
>
> -DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL);
> -DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL);
> -DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL);
> -DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL);
> +static DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL);
> +static DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL);
> +static DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL);
> +static DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL);
>
> static struct device_attribute *ahci_shost_attrs[] = {
> &dev_attr_link_power_management_policy,
> diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c
> index 1b392c9..3610353 100644
> --- a/drivers/ata/pata_pcmcia.c
> +++ b/drivers/ata/pata_pcmcia.c
> @@ -136,7 +136,7 @@ static unsigned int ata_data_xfer_8bit(struct ata_device *dev,
> *
> */
>
> -void pcmcia_8bit_drain_fifo(struct ata_queued_cmd *qc)
> +static void pcmcia_8bit_drain_fifo(struct ata_queued_cmd *qc)
> {
> int count;
> struct ata_port *ap;
>
applied
prev parent reply other threads:[~2010-01-20 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 5:03 [PATCH] libata: make functions/variables static Robert Hancock
2010-01-20 19:33 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B575A8D.8010908@garzik.org \
--to=jeff@garzik.org \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).