linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	jgarzik@pobox.com, Reinhard.Tartler@informatik.uni-erlangen.de
Subject: [PATCH #upstream-fixes] libata-sff: remove CONFIG_NO_ATA_LEGACY
Date: Thu, 21 Jan 2010 09:14:02 +0900	[thread overview]
Message-ID: <4B579C4A.3040907@gmail.com> (raw)
In-Reply-To: <20100120142943.GE3580@faui49.informatik.uni-erlangen.de>

CONFIG_NO_ATA_LEGACY isn't used by anyone.  Drop it.

Reported-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Signed-off-by: Tejun Heo <tj@kernel.org>
---
On 01/20/2010 11:29 PM, Christoph Egger wrote:
> 	That's the only place where it is checked for
> NO_ATA_LEGACY. As this Item does appear nowhere in KConfig and
> therefor is not selectable I'm wondering whether that small Code
> fragment should be dropped or a new KConfig option should be added?
> 
> 	Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.

It's supposed to be set by architecture code to prevent SFF controller
attach if it's in legacy mode.  There apparently is no user left.
Trying to find the last user... it seems it hasn't been unused for at
least two year.  I guess it can be removed then.

Thanks!

 drivers/ata/libata-sff.c |    9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 741065c..b9df435 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -2945,15 +2945,6 @@ int ata_pci_sff_activate_host(struct ata_host *host,
 		mask = (1 << 2) | (1 << 0);
 		if ((tmp8 & mask) != mask)
 			legacy_mode = 1;
-#if defined(CONFIG_NO_ATA_LEGACY)
-		/* Some platforms with PCI limits cannot address compat
-		   port space. In that case we punt if their firmware has
-		   left a device in compatibility mode */
-		if (legacy_mode) {
-			printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
-			return -EOPNOTSUPP;
-		}
-#endif
 	}
 
 	if (!devres_open_group(dev, NULL, GFP_KERNEL))

  reply	other threads:[~2010-01-21  0:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 14:29 Unreferenced config in kernel (libata-sff.c) source (NO_ATA_LEGACY) Christoph Egger
2010-01-21  0:14 ` Tejun Heo [this message]
2010-01-21  0:15   ` [PATCH #upstream-fixes] libata-sff: remove CONFIG_NO_ATA_LEGACY Tejun Heo
2010-01-21  4:32     ` Jeff Garzik
2010-01-21 12:04   ` Alan Cox
2010-01-22  0:48     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B579C4A.3040907@gmail.com \
    --to=htejun@gmail.com \
    --cc=Reinhard.Tartler@informatik.uni-erlangen.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=siccegge@stud.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).