From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: ATA 4 KiB sector issues. Date: Tue, 09 Mar 2010 11:49:44 +0900 Message-ID: <4B95B748.5080902@kernel.org> References: <4B947393.2050002@kernel.org> <20100308195847.GC18077@nb.net.home> <4B95B39C.70402@kernel.org> <4B95B5A2.2090902@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:48312 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072Ab0CICvw (ORCPT ); Mon, 8 Mar 2010 21:51:52 -0500 In-Reply-To: <4B95B5A2.2090902@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Karel Zak , "Martin K. Petersen" , "linux-ide@vger.kernel.org" , lkml , Daniel Taylor , Mark Lord , tytso@mit.edu, "H. Peter Anvin" , hirofumi@mail.parknet.co.jp, Andrew Morton , Alan Cox , irtiger@gmail.com, Matthew Wilcox , aschnell@suse.de, knikanth@suse.de, jdelvare@suse.de, Jim Meyering Hello, On 03/09/2010 11:42 AM, Jeff Garzik wrote: > On 03/08/2010 09:34 PM, Tejun Heo wrote: >> libata is broken for logical 4KiB ATA devices tho. I'll fix it up. > > Does libata-dev.git#sectsize miss any details? I haven't looked at it yet. I'll review it soon but the thing is without actual hardware it would be a bit difficult to tell. It's not only the drivers. I have this mighty unhappy feeling that some controllers (especially some of the SATA ones with internal state machine to emulate SFF) would be sniffing the commands and making the wrong assumption if 4KiB logical sector size is used, so we'll need to test various controllers. Some PATA-SATA bridge chips will definitely be having problems too. Then there are the USB and other bridges too but well those aren't libata's problem at least. :-) Thanks. -- tejun