Re: [PATCH #upstream-fixes 3/3] ahci: implement AHCI_HFLAG_NO_FPDMA_AA and update NV quirks

[Tejun Heo <tj@kernel.org>]

Hello,

On 03/12/2010 09:08 AM, Robert Hancock wrote:
> On 03/10/2010 08:40 PM, Tejun Heo wrote:
>> It turns out different generations of MCPs have differing quirks.
>>
>> * MCP 65-73 : FPDMA AA broken, lies about PMP support, forgets to
>> report NCQ
>> * MCP 77-79 : FPDMA AA broken, lies about PMP support
>> * MCP 89    : FPDMA AA broken
>>
>> Instead of turngin off FPDMA AA on all NVIDIAs, implement
>> HFLAG_NO_FPDMA_AA, define additional board IDs and apply necessary
>> quirks.
>>
>> This fixes bko#15481 and the list of quirks is verified by Peer Chen.
>>
>>    http://bugzilla.kernel.org/show_bug.cgi?id=15481
>>
>> Signed-off-by: Tejun Heo<tj@kernel.org>
>> Cc: Peer Chen<pchen@nvidia.com>
> 
> Is the FPDMA AA problem going to be fixed in whatever follows MCP89?
> This change is only safe if it will be, since a new chipset will fall
> into the generic case and it'll get turned back on.

Yeap, it would be great if NVIDIA fixes it but that said blacklisting
by default usually isn't a very good idea because it often falls
through the crack and after a while not many people remember what
happened when.  If NVIDIA doesn't fix the next revision, we'll know
soon enough.

Thanks.

-- 
tejun