From: Tejun Heo <tj@kernel.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linux-ide@vger.kernel.org
Subject: Re: [RFC] ata/core: don't enable the interrupt while activating the host
Date: Thu, 25 Mar 2010 09:30:25 +0900 [thread overview]
Message-ID: <4BAAAEA1.9040906@kernel.org> (raw)
In-Reply-To: <20100311220417.GA16022@Chamillionaire.breakpoint.cc>
Hello,
On 03/12/2010 07:04 AM, Sebastian Andrzej Siewior wrote:
> I just migrated from ide_platform to pata_platform on my Swarm/Mips
> board. This resulted in "nobody cared" during request_irq().
> The only difference I noticed between ATA and IDE before registering the
> interrupt handler is that IDE does not enable the interrupt.
> After removing the flag it looks like the controller is working with the
> ATA layer.
>
> If I flip the polarity of the interrupt, I see the "nobody cared"
> message shortly after seeing ata_sff_softreset() during boot. So I tried
> to perform the software reset with ATA_SRST before requesting the
> interrupt hoping that it makes interrupt go away. It did not so.
>
> Does anyone have an idea what might go wrong here?
ata_host_start() calls ata_eh_freeze_port() on each port which is
supposed to block the IRQs. For pata_platform, the callback is
libata-sff.c::ata_sff_freeze() which does all that's necessary. Can
you please play with ata_sff_freeze() and find out why it's not
working?
Thanks.
--
tejun
next prev parent reply other threads:[~2010-03-25 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 22:04 [RFC] ata/core: don't enable the interrupt while activating the host Sebastian Andrzej Siewior
2010-03-25 0:30 ` Tejun Heo [this message]
2010-03-25 22:04 ` Sebastian Andrzej Siewior
2010-03-25 23:54 ` Tejun Heo
2010-04-06 9:45 ` Sebastian Andrzej Siewior
2010-04-06 10:00 ` Sergei Shtylyov
2010-04-06 21:56 ` Tejun Heo
2010-04-07 7:52 ` Sebastian Andrzej Siewior
2010-04-13 14:38 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAAAEA1.9040906@kernel.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox