linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH #upstream-fixes] libata-sff: don't whine on spurious IRQ
@ 2010-03-31  7:41 Tejun Heo
  2010-04-06 14:57 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2010-03-31  7:41 UTC (permalink / raw)
  To: Jeff Garzik, linux-ide@vger.kernel.org

On configurations where IRQ line is shared with a different
controller, spurious IRQs may happen continuously.  The message was
put there primarily for debugging anyway.  Kill it.

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 drivers/ata/libata-sff.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 2774772..9d20f7a 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1815,10 +1815,6 @@ retry:
 			    !ap->ops->sff_irq_check(ap))
 				continue;

-			if (printk_ratelimit())
-				ata_port_printk(ap, KERN_INFO,
-						"clearing spurious IRQ\n");
-
 			if (idle & (1 << i)) {
 				ap->ops->sff_check_status(ap);
 				ap->ops->sff_irq_clear(ap);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH #upstream-fixes] libata-sff: don't whine on spurious IRQ
  2010-03-31  7:41 [PATCH #upstream-fixes] libata-sff: don't whine on spurious IRQ Tejun Heo
@ 2010-04-06 14:57 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2010-04-06 14:57 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-ide@vger.kernel.org

On 03/31/2010 03:41 AM, Tejun Heo wrote:
> On configurations where IRQ line is shared with a different
> controller, spurious IRQs may happen continuously.  The message was
> put there primarily for debugging anyway.  Kill it.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> ---
>   drivers/ata/libata-sff.c |    4 ----
>   1 file changed, 4 deletions(-)

applied



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-06 15:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-31  7:41 [PATCH #upstream-fixes] libata-sff: don't whine on spurious IRQ Tejun Heo
2010-04-06 14:57 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).