From: Tejun Heo <tj@kernel.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-ide@vger.kernel.org, debian-kernel@lists.debian.org
Subject: Re: Working around bogus HPAs in libata
Date: Tue, 06 Apr 2010 11:01:28 +0900 [thread overview]
Message-ID: <4BBA95F8.7070909@kernel.org> (raw)
In-Reply-To: <1270245450.12516.187.camel@localhost>
Hello,
On 04/03/2010 06:57 AM, Ben Hutchings wrote:
> Several distributions have turned on the switch by default. As I said
> previously, this turned out to be a bad idea.
Heh, yeah, I did that on openSUSE which was mandatory for backward
compatibility because ide unlocked HPA by default (at least on
openSUSE). Do you know how common are these problem cases w/ default
HPA unlocking? Diddling with HPAs and writing stuff to disks from
BIOS is generally a very bad idea because it means that switching BIOS
options or attaching a hard drive to a different motherboard can lead
to data corruption.
>> Does the following patch work as expected?
...
> So, this looks good, but I'm slightly disturbed by the multiple
> 'capacity change' messages when using libata.
I'll see where those multiple messages are coming from.
> Also, the warnings in ata_dev_revalidate() should not be shown when
> we are deliberately changing capacity.
Given that this is an ugly situation, I don't think it's a bad idea to
emit ugly messages.
> My test case also revealed a bug in the partition scanning retry:
> partition 2 is an extended partition and wholly within the HPA, so the
> extended partition table is not accessible until the HPA is disabled.
> But it is not rescanned after the HPA is disabled. However, this is is
> consistent between IDE and libata drivers and will not be a regression
> when making the transition.
Ah... I see, but let's fix that up too. It could be worse to have
half working workaround than not working around at all. I'll update
the patch once the currently pending HPA updates are in.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-04-06 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 17:25 Working around bogus HPAs in libata Ben Hutchings
2010-04-02 3:24 ` Tejun Heo
2010-04-02 21:57 ` Ben Hutchings
2010-04-06 2:01 ` Tejun Heo [this message]
2010-04-06 2:28 ` Ben Hutchings
2010-04-06 2:33 ` Tejun Heo
2010-04-24 2:26 ` Ben Hutchings
2010-04-24 5:35 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBA95F8.7070909@kernel.org \
--to=tj@kernel.org \
--cc=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).