* [PATCH #upstream-fixes] sata_nv: use ata_pci_sff_activate_host() instead of ata_host_activate()
@ 2010-05-14 9:48 Tejun Heo
2010-05-14 21:12 ` Jeff Garzik
2010-05-15 2:07 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Tejun Heo @ 2010-05-14 9:48 UTC (permalink / raw)
To: Jeff Garzik, linux-ide@vger.kernel.org, stable, Robert Hancock
sata_nv was incorrectly using ata_host_activate() instead of
ata_pci_sff_activate_host() leading to IRQ assignment failure in
legacy mode. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Robert Hancock <hancockr@shaw.ca>
Cc: stable@kernel.org
---
drivers/ata/sata_nv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: ata/drivers/ata/sata_nv.c
===================================================================
--- ata.orig/drivers/ata/sata_nv.c
+++ ata/drivers/ata/sata_nv.c
@@ -2479,8 +2479,7 @@ static int nv_init_one(struct pci_dev *p
}
pci_set_master(pdev);
- return ata_host_activate(host, pdev->irq, ipriv->irq_handler,
- IRQF_SHARED, ipriv->sht);
+ return ata_pci_sff_activate_host(host, ipriv->irq_handler, ipriv->sht);
}
#ifdef CONFIG_PM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH #upstream-fixes] sata_nv: use ata_pci_sff_activate_host() instead of ata_host_activate()
2010-05-14 9:48 [PATCH #upstream-fixes] sata_nv: use ata_pci_sff_activate_host() instead of ata_host_activate() Tejun Heo
@ 2010-05-14 21:12 ` Jeff Garzik
2010-05-14 22:05 ` Tejun Heo
2010-05-15 2:07 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2010-05-14 21:12 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide@vger.kernel.org, stable, Robert Hancock
On 05/14/2010 05:48 AM, Tejun Heo wrote:
> sata_nv was incorrectly using ata_host_activate() instead of
> ata_pci_sff_activate_host() leading to IRQ assignment failure in
> legacy mode. Fix it.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Cc: Robert Hancock<hancockr@shaw.ca>
> Cc: stable@kernel.org
> ---
> drivers/ata/sata_nv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: ata/drivers/ata/sata_nv.c
> ===================================================================
> --- ata.orig/drivers/ata/sata_nv.c
> +++ ata/drivers/ata/sata_nv.c
> @@ -2479,8 +2479,7 @@ static int nv_init_one(struct pci_dev *p
> }
>
> pci_set_master(pdev);
> - return ata_host_activate(host, pdev->irq, ipriv->irq_handler,
> - IRQF_SHARED, ipriv->sht);
> + return ata_pci_sff_activate_host(host, ipriv->irq_handler, ipriv->sht);
hmmmm. I agree 100% with this patch, but is it a recent regression?
At -rc7, we are trying hard to only include fixes for regressions.
Around -rc1, I would stuff this into #upstream-fixes without hesitation.
But now, I'm thinking #upstream.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH #upstream-fixes] sata_nv: use ata_pci_sff_activate_host() instead of ata_host_activate()
2010-05-14 21:12 ` Jeff Garzik
@ 2010-05-14 22:05 ` Tejun Heo
0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2010-05-14 22:05 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide@vger.kernel.org, stable, Robert Hancock
Hello,
On 05/14/2010 11:12 PM, Jeff Garzik wrote:
> hmmmm. I agree 100% with this patch, but is it a recent regression?
It's more than a year old at least. It's a bit surprising that no one
reported this before.
> At -rc7, we are trying hard to only include fixes for regressions.
>
> Around -rc1, I would stuff this into #upstream-fixes without hesitation.
> But now, I'm thinking #upstream.
Yeap, sure. We can wait some time after it makes -rc1 and then push
it through -stable.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH #upstream-fixes] sata_nv: use ata_pci_sff_activate_host() instead of ata_host_activate()
2010-05-14 9:48 [PATCH #upstream-fixes] sata_nv: use ata_pci_sff_activate_host() instead of ata_host_activate() Tejun Heo
2010-05-14 21:12 ` Jeff Garzik
@ 2010-05-15 2:07 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2010-05-15 2:07 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide@vger.kernel.org, stable, Robert Hancock
On 05/14/2010 05:48 AM, Tejun Heo wrote:
> sata_nv was incorrectly using ata_host_activate() instead of
> ata_pci_sff_activate_host() leading to IRQ assignment failure in
> legacy mode. Fix it.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Cc: Robert Hancock<hancockr@shaw.ca>
> Cc: stable@kernel.org
> ---
> drivers/ata/sata_nv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
applied #upstream
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-15 2:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-14 9:48 [PATCH #upstream-fixes] sata_nv: use ata_pci_sff_activate_host() instead of ata_host_activate() Tejun Heo
2010-05-14 21:12 ` Jeff Garzik
2010-05-14 22:05 ` Tejun Heo
2010-05-15 2:07 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).