From: Jeff Garzik <jgarzik@pobox.com>
To: Harry Zhang <harry.zhang@amd.com>
Cc: linux-ide@vger.kernel.org, tj@kernel.org, shane.huang@amd.com
Subject: Re: [PATCH 1/2 v2] ahci: EM message type auto detect
Date: Fri, 14 May 2010 17:24:24 -0400 [thread overview]
Message-ID: <4BEDBF88.4030906@pobox.com> (raw)
In-Reply-To: <1272014839.3594.41.camel@zm-desktop>
On 04/23/2010 05:27 AM, Harry Zhang wrote:
> To detect enclosure management message type automatically at driver
> initialization, instead of using module parameter "ahci_em_messages".
>
> Signed-off-by: Harry Zhang<harry.zhang@amd.com>
> ---
> v2: Move this patch to the first one.
>
> drivers/ata/ahci.c | 2 +-
> drivers/ata/ahci.h | 8 +++++++-
> drivers/ata/libahci.c | 38 ++++++++++++++++++++------------------
> 3 files changed, 28 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index c44d112..8ca16f5 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1185,7 +1185,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> /* set enclosure management message type */
> if (ap->flags& ATA_FLAG_EM)
> - ap->em_message_type = ahci_em_messages;
> + ap->em_message_type = hpriv->em_msg_type;
>
>
> /* disabled/not-implemented port */
you missed ahci_platform.c update.
applied 1-2, and fixed up this problem
prev parent reply other threads:[~2010-05-14 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 9:27 [PATCH 1/2 v2] ahci: EM message type auto detect Harry Zhang
2010-04-23 9:52 ` Tejun Heo
2010-05-14 21:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEDBF88.4030906@pobox.com \
--to=jgarzik@pobox.com \
--cc=harry.zhang@amd.com \
--cc=linux-ide@vger.kernel.org \
--cc=shane.huang@amd.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox