From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Matthew Garrett <mjg@redhat.com>,
Marc Dionne <marc.c.dionne@gmail.com>,
Robert Hancock <hancockrwd@gmail.com>
Subject: Re: [PATCH #upstream-fixes] ahci: redo stopping DMA engines on empty ports
Date: Mon, 07 Jun 2010 16:08:43 -0400 [thread overview]
Message-ID: <4C0D51CB.2060908@garzik.org> (raw)
In-Reply-To: <4C0CF0DC.7060901@kernel.org>
On 06/07/2010 09:15 AM, Tejun Heo wrote:
> Commit 96d60303fd (ahci: Turn off DMA engines when there's no device)
> implemented stopping DMA engines on empty ports but it used single
> sampling of status registers to determine device presence which led to
> disabling of DMA engines on occupied ports. Do it after all EH
> actions are complete using device presence state determined by EH.
> This avoids spurious disabling of DMA engines and simplifies the code.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Tested-by: Marc Dionne<marc.c.dionne@gmail.com>
> Cc: Matthew Garrett<mjg@redhat.com>
> Cc: Robert Hancock<hancockrwd@gmail.com>
> ---
> drivers/ata/libahci.c | 21 +++------------------
> 1 file changed, 3 insertions(+), 18 deletions(-)
applied
prev parent reply other threads:[~2010-06-07 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 13:15 [PATCH #upstream-fixes] ahci: redo stopping DMA engines on empty ports Tejun Heo
2010-06-07 20:08 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0D51CB.2060908@garzik.org \
--to=jeff@garzik.org \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=marc.c.dionne@gmail.com \
--cc=mjg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox