From: Tejun Heo <tj@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Colin Tuckley <colin.tuckley@arm.com>
Subject: Re: [PATCH] sata_sil24: Use memory barriers before issuing commands
Date: Thu, 10 Jun 2010 17:24:33 +0200 [thread overview]
Message-ID: <4C1103B1.7050307@kernel.org> (raw)
In-Reply-To: <20100610145706.15588.4562.stgit@e102109-lin.cambridge.arm.com>
On 06/10/2010 04:57 PM, Catalin Marinas wrote:
> The data in the cmd_block buffers may reach the main memory after the
> writel() to the device ports. This patch introduces two calls to wmb()
> to ensure the relative ordering.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Tested-by: Colin Tuckley <colin.tuckley@arm.com>
> Cc: Tejun Heo <tj@kernel.org>
Can you please add comments explaining why they're needed?
Thanks.
--
tejun
next prev parent reply other threads:[~2010-06-10 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 14:57 [PATCH] sata_sil24: Use memory barriers before issuing commands Catalin Marinas
2010-06-10 15:24 ` Tejun Heo [this message]
2010-06-26 2:32 ` Grant Grundler
2010-06-28 9:21 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1103B1.7050307@kernel.org \
--to=tj@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=colin.tuckley@arm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).