From: Tejun Heo <tj@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Colin Tuckley <colin.tuckley@arm.com>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH v2] sata_sil24: Use memory barriers before issuing commands
Date: Thu, 10 Jun 2010 18:12:13 +0200 [thread overview]
Message-ID: <4C110EDD.2010409@kernel.org> (raw)
In-Reply-To: <20100610160212.18091.29856.stgit@e102109-lin.cambridge.arm.com>
On 06/10/2010 06:02 PM, Catalin Marinas wrote:
> The data in the cmd_block buffers may reach the main memory after the
> writel() to the device ports. This patch introduces two calls to wmb()
> to ensure the relative ordering.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Tested-by: Colin Tuckley <colin.tuckley@arm.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Jeff Garzik <jeff@garzik.org>
I suppose you have tested and verified that this is actually
necessary, right? I've been looking through the docs but couldn't
find anything which described the ordering between writes to main
memory and write[bwl]()'s. One thing that kind of bothers me is that
r/wmb()'s are for ordering memory accesses among CPUs which
participate in cache coherency protocol and although it may work right
in the above case I'm not really sure whether this is the right thing
to do. Do you have more information on the subject?
Thanks.
--
tejun
next prev parent reply other threads:[~2010-06-10 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 16:02 [PATCH v2] sata_sil24: Use memory barriers before issuing commands Catalin Marinas
2010-06-10 16:12 ` Tejun Heo [this message]
2010-06-10 16:23 ` Catalin Marinas
2010-06-10 16:42 ` Catalin Marinas
2010-06-11 0:43 ` Robert Hancock
2010-06-11 1:38 ` Nick Piggin
2010-06-11 9:16 ` FUJITA Tomonori
2010-06-11 9:41 ` Catalin Marinas
2010-06-11 10:11 ` Nick Piggin
2010-06-11 11:04 ` Catalin Marinas
2010-06-12 1:30 ` Robert Hancock
2010-06-15 11:10 ` Catalin Marinas
2010-06-15 11:31 ` Nick Piggin
2010-06-19 22:32 ` Catalin Marinas
2010-06-14 0:35 ` FUJITA Tomonori
2010-06-23 13:00 ` Mark Lord
2010-06-10 20:14 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C110EDD.2010409@kernel.org \
--to=tj@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=colin.tuckley@arm.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).