From: Jeff Garzik <jgarzik@pobox.com>
To: Dan Carpenter <error27@gmail.com>, Tejun Heo <tj@kernel.org>,
Robert Hancock <hancockrwd@gmail.com>,
Vivek Mahajan <vivek.mahajan@freescale.com>,
linux-ide@vger.kernel.org, linux-kern
Subject: Re: [patch] sata_sil24: memset() overflow
Date: Thu, 10 Jun 2010 16:14:35 -0400 [thread overview]
Message-ID: <4C1147AB.5050604@pobox.com> (raw)
In-Reply-To: <20100609120153.GF5483@bicker>
On 06/09/2010 08:01 AM, Dan Carpenter wrote:
> cb->atapi.cdb is an array of 16 u8 elements. The call too memset()
> would set the first part of the sge array to zero as well. It's not
> a packed struct.
>
> This one has been around for five years. I found it with Smatch. I
> think the reason no one has seen it before is because we normally call
> sil24_fill_sg() and that overwrites sge with proper information?
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
> ---
> I don't have this hardware myself so I can't test it. Sorry. :(
>
> diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
> index e925051..9e459eb 100644
> --- a/drivers/ata/sata_sil24.c
> +++ b/drivers/ata/sata_sil24.c
> @@ -865,7 +865,7 @@ static void sil24_qc_prep(struct ata_queued_cmd *qc)
> } else {
> prb =&cb->atapi.prb;
> sge = cb->atapi.sge;
> - memset(cb->atapi.cdb, 0, 32);
> + memset(cb->atapi.cdb, 0, sizeof(cb->atapi.cdb));
> memcpy(cb->atapi.cdb, qc->cdb, qc->dev->cdb_len);
applied
prev parent reply other threads:[~2010-06-10 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 12:01 [patch] sata_sil24: memset() overflow Dan Carpenter
2010-06-09 12:24 ` Tejun Heo
2010-06-10 20:14 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1147AB.5050604@pobox.com \
--to=jgarzik@pobox.com \
--cc=error27@gmail.com \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vivek.mahajan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).