From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [patch] sata_sil24: memset() overflow Date: Thu, 10 Jun 2010 16:14:35 -0400 Message-ID: <4C1147AB.5050604@pobox.com> References: <20100609120153.GF5483@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:46458 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089Ab0FJUOj (ORCPT ); Thu, 10 Jun 2010 16:14:39 -0400 In-Reply-To: <20100609120153.GF5483@bicker> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Dan Carpenter , Tejun Heo , Robert Hancock , Vivek Mahajan , linux-ide@vger.kernel.org, linux-kern On 06/09/2010 08:01 AM, Dan Carpenter wrote: > cb->atapi.cdb is an array of 16 u8 elements. The call too memset() > would set the first part of the sge array to zero as well. It's not > a packed struct. > > This one has been around for five years. I found it with Smatch. I > think the reason no one has seen it before is because we normally call > sil24_fill_sg() and that overwrites sge with proper information? > > Signed-off-by: Dan Carpenter > --- > I don't have this hardware myself so I can't test it. Sorry. :( > > diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c > index e925051..9e459eb 100644 > --- a/drivers/ata/sata_sil24.c > +++ b/drivers/ata/sata_sil24.c > @@ -865,7 +865,7 @@ static void sil24_qc_prep(struct ata_queued_cmd *qc) > } else { > prb =&cb->atapi.prb; > sge = cb->atapi.sge; > - memset(cb->atapi.cdb, 0, 32); > + memset(cb->atapi.cdb, 0, sizeof(cb->atapi.cdb)); > memcpy(cb->atapi.cdb, qc->cdb, qc->dev->cdb_len); applied