From: Tejun Heo <tj@kernel.org>
To: Harry Zhang <harry.zhang@amd.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org, shane.Huang@amd.com
Subject: Re: [PATCH #upstream-fixes] libahci: Fix bug in storing EM messages
Date: Thu, 24 Jun 2010 10:30:30 +0200 [thread overview]
Message-ID: <4C2317A6.6000606@kernel.org> (raw)
In-Reply-To: <1277350463.8158.3.camel@zm-desktop>
On 06/24/2010 05:34 AM, Harry Zhang wrote:
> In function ahci_store_em_buffer(), if the input (signed char*) buffer
> contains negative data, the constructed 32-bit long message data may
> be wrong.
Explaining why it was wrong would be nice. Also is adding a comment
explaining why the uchar pointer is needed. Nothing fancy, just simple
/* avoid sign extension */ should do.
Other than that, Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2010-06-24 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 3:34 [PATCH #upstream-fixes] libahci: Fix bug in storing EM messages Harry Zhang
2010-06-24 8:30 ` Tejun Heo [this message]
2010-07-01 19:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2317A6.6000606@kernel.org \
--to=tj@kernel.org \
--cc=harry.zhang@amd.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=shane.Huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).